-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to Ubuntu 22.04. #3188
Conversation
ℹ️ blocked until new Alpine release with OpenSSL 3 |
23d3cab
to
42da2be
Compare
Codecov Report
@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
- Coverage 98.58% 98.19% -0.39%
==========================================
Files 113 110 -3
Lines 3384 3320 -64
==========================================
- Hits 3336 3260 -76
- Misses 48 60 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ℹ️ last OpenSSL problem was fixed at ruby/openssl#541 and is included in latest release. But I'm not still sure if there is any value in this PR. 🤔 |
42da2be
to
ca879ad
Compare
@simi would you be able to elaborate? Is it because you rather wait for the new Alpine release to upgrade both prod and ci |
I'm not sure it is worth it to add |
Gotcha! Thanks for providing that info, I think we can wait for the next Ruby release then too 👍 |
Unless this resolves a security issue in prod, we shouldn't have to update. |
I'll strip down this PR to just update the CI runners. OpenSSL would get pulled in in https://github.com/rubygems/rubygems.org/pull/3337/files (on both sides, into app as default gem and also into docker container using Alpine 3.17 if I understand it well). Btw. we're already locked at OpenSSL 3.0.1 gem. Line 278 in a293631
|
👍 There is only concern about Ubuntu 22.04 with Ruby 3.0. The current ruby version is 3.1, There is no reason to stay Ubuntu 20.04. |
ℹ️ Originally I tried to upgrade to Ubuntu 22.04, but there were problems with OpenSSL 3.0. It seems some API was removed with proper replacement. I have asked at ruby/openssl#480 (comment) for more info.For now, we can (at least) migrate to Ubuntu 20.04, since Ubuntu 18.04 is deprecated for GitHub Actions.https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/