From 01a07370e23f28416eb0463a8d5870416f47b3ae Mon Sep 17 00:00:00 2001 From: "siddarth.msv" <82795818+Sidddddarth@users.noreply.github.com> Date: Mon, 25 Sep 2023 15:47:03 +0530 Subject: [PATCH] chore: fix archiver test - inconsistent number of files (#3902) edited test logs to help debug. Re: files uploaded per source in archiver_test --- archiver/archiver_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/archiver/archiver_test.go b/archiver/archiver_test.go index f3fb4415ea..59b831844d 100644 --- a/archiver/archiver_test.go +++ b/archiver/archiver_test.go @@ -7,6 +7,7 @@ import ( "fmt" "os" "strconv" + "strings" "sync/atomic" "testing" "time" @@ -22,6 +23,7 @@ import ( "github.com/rudderlabs/rudder-go-kit/bytesize" "github.com/rudderlabs/rudder-go-kit/filemanager" "github.com/rudderlabs/rudder-go-kit/testhelper/docker/resource" + trand "github.com/rudderlabs/rudder-go-kit/testhelper/rand" backendconfig "github.com/rudderlabs/rudder-server/backend-config" "github.com/rudderlabs/rudder-server/jobsdb" "github.com/rudderlabs/rudder-server/utils/misc" @@ -32,7 +34,7 @@ import ( func TestJobsArchival(t *testing.T) { var ( - prefix = "some-prefix" + prefix = trand.String(10) minioResource []*destination.MINIOResource // test data - contains jobs from 3 workspaces(1 - 1 source, 2 & 3 - 2 sources each) @@ -171,7 +173,9 @@ func TestJobsArchival(t *testing.T) { fileIter := fm.ListFilesWithPrefix(context.Background(), "", prefix, 20) files, err := getAllFileNames(fileIter) require.NoError(t, err) - require.Equal(t, sourcesPerWorkspace[i], len(files)) + require.Equal(t, sourcesPerWorkspace[i], len(files), + fmt.Sprintf("found files: %s for workspace: %s", strings.Join(files, ", "), workspace), + ) for j, file := range files { downloadFile, err := os.CreateTemp(t.TempDir(), fmt.Sprintf("backedupfile%d%d", i, j))