fix: cover type check on all ts files #372
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }, | ||
| "./*": { | ||
| "types": "./dist/*.d.mts", | ||
| "import": "./dist/*.mjs", | ||
| "require": "./dist/*.js" |
There was a problem hiding this comment.
cannot use, some type might be missing
| @@ -1,11 +1,19 @@ | |||
| { | |||
| "extends": "../../tsconfig.json", | |||
There was a problem hiding this comment.
@himself65 what's the advantage of this dependency? a disadvantage that I see is that it makes it more difficult to separate create-llama out of this repository (which is something we might want to do as it grows more and more)
There was a problem hiding this comment.
I originally wanted to make typescript check all ts files because some examples code was already outdated but we didn't know it. I think it's very simple to separate create-llama, just copy upstream tsconfig and merge it into one tsconfig.
There was a problem hiding this comment.
I originally wanted to make typescript check all ts files because some examples code was already outdated but we didn't know it.
Yes that's a very good idea. I just wondered if we need this tsconfig.json dependency for this?
Use ts monorepo to cover all ts files. Make type check in CI to make sure all files are type correct
Similar PR: dai-shi/waku#132, toeverything/AFFiNE#2732