Create dedicated test for draft PR events

runatlantis · Apr 10, 2020 · 81a3742 · 81a3742
1 parent d41d0f4
commit 81a3742
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/server/events/event_parser_test.go b/server/events/event_parser_test.go
@@ -131,14 +131,6 @@ func TestParseGithubPullEvent(t *testing.T) {
 	_, _, _, _, _, err = parser.ParseGithubPullEvent(&testEvent)
 	ErrEquals(t, "sender.login is null", err)
 
-	// verify that draft PRs are treated as 'other' events
-	testEvent = deepcopy.Copy(PullEvent).(github.PullRequestEvent)
-	draftPR := true
-	testEvent.PullRequest.Draft = &draftPR
-	_, evType, _, _, _, err := parser.ParseGithubPullEvent(&testEvent)
-	Ok(t, err)
-	Equals(t, models.OtherPullEvent, evType)
-
 	actPull, evType, actBaseRepo, actHeadRepo, actUser, err := parser.ParseGithubPullEvent(&PullEvent)
 	Ok(t, err)
 	expBaseRepo := models.Repo{
@@ -168,6 +160,16 @@ func TestParseGithubPullEvent(t *testing.T) {
 	Equals(t, models.User{Username: "user"}, actUser)
 }
 
+func TestParseGithubPullEventFromDraft(t *testing.T) {
+	// verify that draft PRs are treated as 'other' events
+	testEvent := deepcopy.Copy(PullEvent).(github.PullRequestEvent)
+	draftPR := true
+	testEvent.PullRequest.Draft = &draftPR
+	_, evType, _, _, _, err := parser.ParseGithubPullEvent(&testEvent)
+	Ok(t, err)
+	Equals(t, models.OtherPullEvent, evType)
+}
+
 func TestParseGithubPullEvent_EventType(t *testing.T) {
 	cases := []struct {
 		action string