Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge could merge unapplied infra changes #1006

Closed
parmouraly opened this issue Apr 24, 2020 · 1 comment
Closed

Auto-merge could merge unapplied infra changes #1006

parmouraly opened this issue Apr 24, 2020 · 1 comment

Comments

@parmouraly
Copy link
Contributor

Version: 0.11.1

Issue
When auto-merge is enabled, it can happen that Atlantis will merge a PR with code that would normally result to infrastructure changes, but without ensuring these changes are applied.
This means you end up with drift between your infrastructure state and the code representing it in your master branch.

Expected behaviour
Even with auto-merge enabled, Atlantis should never decide to merge a PR with code that would normally generate a plan diff which has not been successfully applied

Example/reproduce
image

@parmouraly
Copy link
Contributor Author

parmouraly commented Apr 24, 2020

This could be a fix

#1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant