Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting lock/plan deletes all plans for that workspace #215

Closed
lkysow opened this issue Aug 8, 2018 · 8 comments · Fixed by #3553
Closed

Deleting lock/plan deletes all plans for that workspace #215

lkysow opened this issue Aug 8, 2018 · 8 comments · Fixed by #3553
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user waiting-on-review Waiting for a review from a maintainer

Comments

@lkysow
Copy link
Member

lkysow commented Aug 8, 2018

With the current implementation, deleting a lock for any directory in a workspace deletes the plans for other directories in that same workspace. Instead, we should just delete the lock and plan for that workspace AND directory combination.
@lkysow lkysow added the bug Something isn't working label Aug 8, 2018
@jamengual
Copy link
Contributor

@lilincmu is this still the case?

@jamengual jamengual added waiting-on-review Waiting for a review from a maintainer waiting-on-response Waiting for a response from the user labels Aug 26, 2022
@github-actions
Copy link

This issue is stale because it has been open for 6 months with no activity. Remove stale label or comment or this will be closed in 1 month.'

@github-actions github-actions bot added the Stale label Feb 26, 2023
@rouge8
Copy link

rouge8 commented Mar 11, 2023

This appears to still be the case.

@nitrocode nitrocode removed the Stale label Mar 11, 2023
@github-actions
Copy link

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.'

@github-actions github-actions bot added the Stale label Apr 15, 2023
@rouge8
Copy link

rouge8 commented Apr 15, 2023

This is still an issue

@jamengual jamengual removed the Stale label Apr 15, 2023
@github-actions
Copy link

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.'

@github-actions github-actions bot added the Stale label May 17, 2023
@rouge8
Copy link

rouge8 commented May 17, 2023

Still an issue I think

@github-actions github-actions bot removed the Stale label May 18, 2023
meringu pushed a commit to meringu/atlantis that referenced this issue May 29, 2023
@lkysow
Merge pull request runatlantis#215 from hootsuite/safe-shutdown
0109bcf 
Shut down server safely on SIGINT/TERM. Fixes runatlantis#21
@github-actions
Copy link

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.'

@github-actions github-actions bot added the Stale label Jun 18, 2023
@X-Guardian X-Guardian mentioned this issue Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Discarding a Plan Causes the Whole Working Directory to be Deleted X-Guardian/atlantis
5 participants
@rouge8 @lkysow @jamengual @nitrocode @lilincmu