Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket server comments too long #280

Closed
lkysow opened this issue Sep 17, 2018 · 7 comments
Closed

Bitbucket server comments too long #280

lkysow opened this issue Sep 17, 2018 · 7 comments
Labels
bug Something isn't working provider/bitbucket quick-win Is obviously something Atlantis should do and will take <4 hrs work

Comments

@lkysow
Copy link
Member

lkysow commented Sep 17, 2018

Bitbucket has a max of 32k chars. Will need to split the output into multiple comments like with GitHub.

Via @BlackTurtle123

@BlackTurtle123
Copy link

Or purge all the "refresh" data would also work I think?
Since the actual changes matter most

@lkysow
Copy link
Member Author

lkysow commented Sep 17, 2018

Yes @majormoses also suggested that. I'll look into it.

@jonboulle
Copy link

Having atlantis purge the refresh data would be great and allow me to remove my poor man's atlantis.yaml workaround:

      - run: terraform plan -refresh -no-color -out $PLANFILE -var-file ./dev.tfvars | fgrep -v \"Refreshing state...\"

@BlackTurtle123
Copy link

Having atlantis purge the refresh data would be great and allow me to remove my poor man's atlantis.yaml workaround:

      - run: terraform plan -refresh -no-color -out $PLANFILE -var-file ./dev.tfvars | fgrep -v \"Refreshing state...\"

I might for now use the poor man's workaround since I am currently doing only a PoC. But yes a "clean" way might be very good

@majormoses
Copy link
Contributor

@BlackTurtle123 if you upgrade to 0.4.11 it will do it for you now I verified it works on my systems.

@kipkoan
Copy link
Contributor

kipkoan commented Nov 16, 2018

I just ran into this same problem. I'll look into fixing this during our next sprint, as we are doing some major refactoring across a lot of repos, which results in some large terraform plans.

$ terraform plan | wc
    338    1449   39121
$ atlantis version
atlantis 0.4.11

(actually running commit deebb22)

Atlantis error:

2018/11/16 22:48:03 command_runner.go:257: [ERROR] Analytics Terraform/zoml-platform#8: 
Unable to comment: making request "POST .../rest/api/1.0/projects/anatf/repos/zoml-platform/pull-requests/8/comments" 
unexpected status code: 400, body: {"errors":[{"context":"text","message":
"Please enter a non-empty value less than 32768 characters","exceptionName":null}]}

@lkysow lkysow added quick-win Is obviously something Atlantis should do and will take <4 hrs work bug Something isn't working labels Dec 3, 2018
@lkysow
Copy link
Member Author

lkysow commented Dec 3, 2018

We can take the code from github_client and split the comment into multiple comments. We just need to use a different separator because we don't use the <details> format for Bitbucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working provider/bitbucket quick-win Is obviously something Atlantis should do and will take <4 hrs work
Projects
None yet
Development

No branches or pull requests

6 participants