Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert relative --data-dir paths to absolute. #10

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Convert relative --data-dir paths to absolute. #10

merged 1 commit into from
Feb 19, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Feb 16, 2018

@codecov
Copy link

codecov bot commented Feb 16, 2018 •
edited
Loading

Codecov Report

Merging #10 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   63.64%   63.63%   -0.02%     
==========================================
  Files          38       38              
  Lines        1766     1771       +5     
==========================================
+ Hits         1124     1127       +3     
- Misses        592      593       +1     
- Partials       50       51       +1
Impacted Files Coverage Δ
cmd/server.go 76.84% <75%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477cc79...e2a02fd. Read the comment docs.

@lkysow lkysow merged commit 486d361 into master Feb 19, 2018
@lkysow lkysow deleted the data-dir branch February 19, 2018 05:34
ghaiszaher referenced this pull request in ghaiszaher/atlantis Oct 7, 2022
@ghaiszaher
Merge pull request #25 from ScaCap/#10_implement-getQueueByLock
761fe20 
#10 Refactoring
meringu pushed a commit to meringu/atlantis that referenced this pull request May 29, 2023
@lkysow
Fixes runatlantis#10. Renaming for consistency (runatlantis#12)
0cb13a9 
Repo owner, name => repoFullName
PullID => PullNum to match GitHub API
PR => Pull to match GitHub API and avoid writing PRID anywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lkysow