-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to globally disable apply #1230
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
+ Coverage 69.95% 69.98% +0.02%
==========================================
Files 71 71
Lines 5362 5380 +18
==========================================
+ Hits 3751 3765 +14
- Misses 1263 1265 +2
- Partials 348 350 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks super good. Can you also update the website flag docs?
@lkysow I have addressed your comments and pushed my changes One issue I see now is the fact that we will not be able to plan multiple PR's because of the locking. I see there is #1212 been raised would this be best as another feature/server-flag that can be used alongside --disable-apply? I would not look to remove locking but if the flag is enabled unlock the repo automatically once the plan has completed allowing other plans to be run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close, thanks for the attention to detail.
I have addressed the last round of comments and re-based, I have left one review comment unresolved as I am not sure how I proceed with that one |
* Add Option to globally disable apply Co-authored-by: Gerald Barker <geraldbarker@mail.com>
* Add Option to globally disable apply Co-authored-by: Gerald Barker <geraldbarker@mail.com>
Implement a new server flag that will disable the ability to run
atlantis apply
, as suggested in #1219