fix: Discarding a Plan Causes the Whole Working Directory to be Deleted

[X-Guardian]

what

• In the Locks Controller DeleteLock function, remove the WorkingDirLocker.TryLock and WorkingDir.DeleteForWorkspace function calls as these are not needed as the function has already called DeleteLockCommand.DeleteLock.
• In the DeleteLockCommand.DeleteLock function, replace the call to deleteWorkingDir with a call to the new function WorkingDir.DeletePlan. Note: projectName has to be hard coded to an empty string as the Locks Controller currently has no knowledge of Atlantis project names.
• Add the WorkingDir.DeletePlan function to the events package with code to build the required plan file path and the delete the file. A logger has also been added to the FileWorkspace type.

why

• Fixes Discarding a Plan Causes the Whole Working Directory to be Deleted #3531
• Fixes Deleting lock/plan deletes all plans for that workspace #215

tests

Tested locally

[jamengual]

@GenPage

[X-Guardian]

Maintainers, this PR is ready for review.

[jamengual]

@GenPage relates to ADRs

[GenPage]

This is a good change but I fear incomplete in the grand scheme of the ADR-002 (#3345 . Right now the workingDir and locks controller don't have a complete understanding of project names which you have found.

The focus with the ADR is to clean up previous code that attempted to add paths to the workingDir/workingDirLocker. It also tries to help contributors understand the call stack to improve unnecessary cloning when operating on repos.

I'm not trying to block the PR. My main concern is around completely removing the workingDir lock for releasing locks/deleting plans. Happy to discuss further.

[X-Guardian]

Hi @GenPage, thanks for the feedback. I understand your comments, and agree that further work is required in the future with regard to the lock handling. I don't believe the changes in this PR block any future changes or make them harder though. Users can still release all locks with the atlantis unlock command and all these changes do is fix the really annoying issue of when you currently release one lock, all plans for the PR are deleted.

[GenPage]

Looks good to me