Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Failed policy checks block apply regardless of mergeable apply requirement #4204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erickearns
Copy link

what

The docs indicate that the mergeable apply requirement needs to be active in order to block applies based on failing policy checks. This isn't true.

why

Simply enabling policy checks appears to cause enforcement of policies_passed requirement for apply.

tests

I use policy checks without the mergeable apply requirement and they block apply when failing.

references

ValidateApplyProject checks PolicyCleared independently from MergeableRequirement (ref)

@erickearns erickearns requested review from a team as code owners February 2, 2024 21:02
@erickearns erickearns requested review from chenrui333, nitrocode and X-Guardian and removed request for a team February 2, 2024 21:02
@github-actions github-actions bot added the docs Documentation label Feb 2, 2024
@erickearns erickearns changed the title (docs) Failed policy checks block apply regardless of mergeable apply requirement docs: Failed policy checks block apply regardless of mergeable apply requirement Feb 2, 2024
@X-Guardian
Copy link
Contributor

Hi @erickearns, can you resolve the conflict on this?

@X-Guardian X-Guardian added the waiting-on-response Waiting for a response from the user label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants