feat: adding support for bitbucket cloud webhook secrets #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almightyfoon
requested review from
jamengual,
lukemassa and
nitrocode
and removed request for
a team
github-actions
bot
added
go
almightyfoon
changed the title
jamengual
reviewed
Feb 22, 2024
jamengual
added
waiting-on-review
|
kindly get this change merged. we are in very much need for this feature. |
119Vik
approved these changes
Jun 19, 2024
|
@almightyfoon, can you resolve the conflicts on this PR? |
X-Guardian
added
waiting-on-response
Signed-off-by: Joshua Spork <almightyfoon@gmail.com>
X-Guardian
reviewed
Nov 5, 2024
| @@ -221,12 +221,19 @@ func (e *VCSEventsController) handleGithubPost(w http.ResponseWriter, r *http.Re | |||
| func (e *VCSEventsController) handleBitbucketCloudPost(w http.ResponseWriter, r *http.Request) { | |||
| eventType := r.Header.Get(bitbucketEventTypeHeader) | |||
| reqID := r.Header.Get(bitbucketCloudRequestIDHeader) | |||
| sig := r.Header.Get(bitbucketServerSignatureHeader) | |||
There was a problem hiding this comment.
Should bitbucketServerSignatureHeader be renamed to bitbucketSignatureHeader if it is now used by both Cloud and Server?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Added support for Bitbucket Cloud Webhook secrets. Bitbucket added support in the cloud offering in October of 2023 Announcement
why
There is an open request for this #3909 and I'm also in need of this feature.
tests
I ran make test, the logic is the same as bitbucketserver.
Test results:
? github.com/runatlantis/atlantis [no test files]
ok github.com/runatlantis/atlantis/cmd 0.113s
ok github.com/runatlantis/atlantis/server (cached)
ok github.com/runatlantis/atlantis/server/controllers (cached)
ok github.com/runatlantis/atlantis/server/controllers/events (cached)
ok github.com/runatlantis/atlantis/server/controllers/templates (cached)
ok github.com/runatlantis/atlantis/server/controllers/websocket (cached)
ok github.com/runatlantis/atlantis/server/core/config (cached)
ok github.com/runatlantis/atlantis/server/core/config/raw (cached)
ok github.com/runatlantis/atlantis/server/core/config/valid (cached)
ok github.com/runatlantis/atlantis/server/core/db (cached)
ok github.com/runatlantis/atlantis/server/core/locking (cached)
ok github.com/runatlantis/atlantis/server/core/redis (cached)
ok github.com/runatlantis/atlantis/server/core/runtime (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/cache (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/common (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/models (cached)
ok github.com/runatlantis/atlantis/server/core/runtime/policy (cached)
ok github.com/runatlantis/atlantis/server/core/terraform (cached)
ok github.com/runatlantis/atlantis/server/events (cached)
ok github.com/runatlantis/atlantis/server/events/command (cached)
ok github.com/runatlantis/atlantis/server/events/models (cached)
ok github.com/runatlantis/atlantis/server/events/terraform/ansi (cached)
ok github.com/runatlantis/atlantis/server/events/vcs (cached)
ok github.com/runatlantis/atlantis/server/events/vcs/bitbucketcloud (cached)
ok github.com/runatlantis/atlantis/server/events/vcs/bitbucketserver (cached)
ok github.com/runatlantis/atlantis/server/events/vcs/common (cached)
ok github.com/runatlantis/atlantis/server/events/webhooks (cached)
ok github.com/runatlantis/atlantis/server/jobs (cached)
ok github.com/runatlantis/atlantis/server/logging (cached)
ok github.com/runatlantis/atlantis/server/metrics (cached)
ok github.com/runatlantis/atlantis/server/recovery (cached)
? github.com/runatlantis/atlantis/testdrive [no test files]
ok github.com/runatlantis/atlantis/server/scheduled (cached)
ok github.com/runatlantis/atlantis/server/utils (cached)
references
Closes #3909