Fix to allow modified files to be excluded #847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
==========================================
+ Coverage 71.83% 71.88% +0.04%
==========================================
Files 65 65
Lines 5213 5221 +8
==========================================
+ Hits 3745 3753 +8
Misses 1183 1183
Partials 285 285
Continue to review full report at Codecov.
|
|
I carried your commits to #865. Thanks for the great fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that setting
when_modifiedto something like["*.tf", "!exclude-me.tf]with a modified list ofexclude-me.tfstill resulted in a plan automatically running. This PR allows files to be excluded using.dockerignore's exclusion syntax, i.e. prepending a!to the path.