-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable cg recolor #6911
base: master
Are you sure you want to change the base?
Re-enable cg recolor #6911
Conversation
Fixed the bug, very minor changes. Somehow forgot a try-catch block which sometimes resulted in a nullpointer exception
Can you make this use the |
Yeah, that’s why I took it down in the first place instead of just pushing a quick fix. I may be tied up for the next couple of days, and since some users requested that this be uploaded again soon, I decided to re-upload it in a working state with only these minor changes. I’ll make the "bigger" changes in the near future if that's okay with you. If not, that's totally fine 👍 |
…with the old method
No need to investigate the scene outside of this content
I'm now using the new preMapLoad event and removed all instances of "setting the scene ID on objects". I'm also no longer trying to call getModel() on despawned Objects. The performance should now be improved substantially - thanks again for the new event! |
Is this one ready to be reviewed? I've been missing this plugin, hope it'll be available soon :) |
Fixed the bug, very minor changes. Somehow forgot a try-catch block which sometimes resulted in a nullpointer exception