Clue scroll notifier #7113
Open
Clue scroll notifier #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue notifications - Updated ClueScrollNotifierPlugin to remove external download logic and rely on local sound resources. - Modified FileManager to use getResourceAsStream() to load the clue.wav sound file directly from the classpath. - Refactored SoundEngine to handle sound playback using local resource
|
|
|
Provided it is only 5 sound files, it would be nicer if you can include them in the plugin resources and just unpack them into the dir on startup instead of fetching remotely. |
LlemonDuck
added
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if it's allowed since the readme prefers us not to download resources on the user's machines but tried to implement this as per this issue: SoaresPT/clue-scroll-notifier#1
Changes: