Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hunter-rumours to 1.3.2 #7120

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Update hunter-rumours to 1.3.2 #7120

merged 3 commits into from
Dec 10, 2024

Conversation

geel9
Copy link
Contributor

@geel9 geel9 commented Dec 7, 2024

  • Correctly tracks hunter creatures caught while a league XP multiplier is active

Joshua Coffey added 2 commits December 6, 2024 22:51
@runelite-github-app
Copy link

runelite-github-app bot commented Dec 7, 2024 •
edited
Loading

hunter-rumours: 173ef2b34e12c8e225f88d695e6c4d4e100cc4b7...3ddd6564bc7d99d7b20da3bbbde4469d97adb394

@geel9 geel9 changed the title Hunter rumours 1 3 2 Update hunter-rumours to 1.3.2 Dec 7, 2024
@tylerwgrass
Copy link
Member

Did you verify normal worlds still work as expected? (I'm not sure how the leagues varbits work in this case).

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 7, 2024
@geel9
Copy link
Contributor Author

geel9 commented Dec 7, 2024

Did you verify normal worlds still work as expected? (I'm not sure how the leagues varbits work in this case).

Yes -- on normal worlds, the varbits are all set to 0, causing getLeaguesXpMultiplier() to return 1.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 7, 2024
@iProdigy iProdigy merged commit 16dec48 into runelite:master Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerwgrass tylerwgrass tylerwgrass approved these changes

@iProdigy iProdigy iProdigy approved these changes

Assignees
No one assigned
Labels
plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geel9 @tylerwgrass @iProdigy