Skip to content

Commit

Permalink
fix: Change the default behavoir for deleting .finch folder to false …
Browse files Browse the repository at this point in the history
…when uninstall (#732)

Issue #, if available:

*Description of changes:*
To make homebrew keep the .finch folder when uninstall, change the
uninstall script default option to not deleting the .finch folder

*Testing done:*
Tested locally by modifying the script after homebrew installation


- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Kevin Li <cnkevin@amazon.com>
  • Loading branch information
KevinLiAWS authored Dec 11, 2023
1 parent 8fd5a70 commit e818743
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions installer-builder/darwin/Resources/uninstall.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ fi
#clean up ~/.finch directory
while true; do
read -r -p "Delete ~/.finch containing persistent user data [Y/n]? " answer
if [[ $answer == "y" || $answer == "Y" || $answer == "" ]]
if [[ $answer == "y" || $answer == "Y" ]]
then
[ -d ~/.finch ] && rm -rf ~/.finch
if [ $? -eq 0 ]
Expand All @@ -59,7 +59,7 @@ while true; do
echo "[4/4] [ERROR] Could not delete ~/.finch" >&2
fi
break
elif [[ $answer == "n" || $answer == "N" ]]
elif [[ $answer == "n" || $answer == "N" || $answer == "" ]]
then
echo "[4/4] Deletion of ~/.finch was aborted."
break
Expand Down

0 comments on commit e818743

Please sign in to comment.