From 14dc837b5831ba43479c4a76e814f796ee6b868f Mon Sep 17 00:00:00 2001
From: Scott Guest <scott.guest@runtimeverification.com>
Date: Fri, 23 Feb 2024 03:22:08 -0800
Subject: [PATCH] Support Java 17 in `kore` submodule (#4032)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In #3736, we updated to Java 17 by configuring the Java version for
`maven-compiler-plugin`.

However - after banging my head against a wall for the past hour
wondering why none of my code is parsing 🙃 - I realized that the `kore`
and `matching` submodules are actually built by `scala-maven-plugin`
rather than `maven-compiler-plugin`, and their Java version must be set
independently.

This PR sets the version for `kore` to Java 17, and
runtimeverification/llvm-backend#993 will do the same for `matching`.
---
 kore/pom.xml | 6 ++++++
 pom.xml      | 7 ++++---
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/kore/pom.xml b/kore/pom.xml
index a70d0a62f32..b98138dc0c3 100644
--- a/kore/pom.xml
+++ b/kore/pom.xml
@@ -79,6 +79,12 @@
             <arg>-language:implicitConversions</arg>
             <arg>-language:postfixOps</arg>
           </args>
+          <javacArgs>
+            <javacArg>-source</javacArg>
+            <javacArg>${java.version}</javacArg>
+            <javacArg>-target</javacArg>
+            <javacArg>${java.version}</javacArg>
+          </javacArgs>
         </configuration>
       </plugin>
     </plugins>
diff --git a/pom.xml b/pom.xml
index cdde5db185b..305b92b4eb1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -75,6 +75,7 @@
     <skipCheckstyleOnWindows>true</skipCheckstyleOnWindows>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.build.type>FastBuild</project.build.type>
+    <java.version>17</java.version>
     <scala.majorVersion>2.12</scala.majorVersion>
     <scala.minorVersion>18</scala.minorVersion>
     <scala.version>${scala.majorVersion}.${scala.minorVersion}</scala.version>
@@ -167,8 +168,8 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>3.7.0</version>
           <configuration>
-            <source>17</source>
-            <target>17</target>
+            <source>${java.version}</source>
+            <target>${java.version}</target>
           </configuration>
         </plugin>
         <!-- Antrun plugin for running arbitrary shell commands (building subprojects) -->
@@ -248,7 +249,7 @@
         <configuration>
           <rules>
             <requireJavaVersion>
-              <version>[11,)</version>
+              <version>[${java.version},)</version>
             </requireJavaVersion>
           </rules>
         </configuration>