Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating CI to be more like rust-bitcoin #667

Open
tcharding opened this issue Mar 27, 2024 · 9 comments
Open

Consider updating CI to be more like rust-bitcoin #667

tcharding opened this issue Mar 27, 2024 · 9 comments

Comments

@tcharding
Copy link
Member

Are any of the recent improvements to CI in rust-bitcoin worth adopting here?

@apoelstra
Copy link
Member

Probably yeah. Though we should wait for the rust-bitcoin CI to settle out a little bit first.

@tcharding
Copy link
Member Author

OMG we are not using the recent/minimal lock files in CI. Shall I re-write CI now?

@sanket1729
Copy link
Member

That would be awesome if you have the time.

@tcharding
Copy link
Member Author

tcharding commented Apr 30, 2024

I have 24 hours in each day!

@apoelstra
Copy link
Member

OMG we are not using the recent/minimal lock files in CI. Shall I re-write CI now?

For what it's worth, I use these files locally, so they are exercised.

But yes, if you have the time and inclination, please rewrite CI here!

To the extent possible, can you try to factor things out of rust-bitcoin into https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools/ rather than copy/pasting the scripts around? I think that would get us to a more sustainable situation regarding CI script maintenance.

@tcharding
Copy link
Member Author

I might as well do that at the same time as doing bitcoincore-rpc, I'll give it a shot today.

@storopoli
Copy link
Contributor

I can help reviewing, please ping me?

@tcharding
Copy link
Member Author

Legend, can do.

@tcharding
Copy link
Member Author

Hey @storopoli, and anyone else, if you want to look there are a bunch of drafts open that I did today that re-write CI to use a shared script that lives in rust-bitcoin-maintainer-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants