Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove outdated caveat #195

Merged
merged 1 commit into from
Jun 4, 2024
Merged

docs: Remove outdated caveat #195

merged 1 commit into from
Jun 4, 2024

Conversation

fowles
Copy link
Contributor

@fowles fowles commented Jun 4, 2024

No description provided.

@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 9371395155

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.971%

Totals Coverage Status
Change from base Build 9370332309: 0.0%
Covered Lines: 1226
Relevant Lines: 2359

💛 - Coveralls

@fowles
Copy link
Contributor Author

fowles commented Jun 4, 2024

allowed_types = [
    "fix",
    "feat",
    "chore",
    "docs",
    "style",
    "refactor",
    "perf",
    "test",
]

If this fails, don't sweat it. We're trying to encourage clear communication and not hinder contributions.
If it is a reasonable issue and you lack time or feel uncomfortable fixing it yourself,
let us know and we can mentor or fix it.
a0f80ef: error Commit is not in Conventional format: Missing type in the commit summary, expected `type: description`

I think I am using docs which is an accepted type.

@epage
Copy link
Collaborator

epage commented Jun 4, 2024

I think I am using docs which is an accepted type.

Its commenting about your commit, rather than you PR. However, as its noted, its not the biggest of deals.

@epage epage merged commit cd521ad into rust-cli:main Jun 4, 2024
13 of 14 checks passed
@fowles fowles deleted the anstyle-1 branch June 4, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants