Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace travis with Github actions #157

Closed
wants to merge 1 commit into from
Closed

Replace travis with Github actions #157

wants to merge 1 commit into from

Conversation

Nukesor
Copy link

@Nukesor Nukesor commented Oct 18, 2020

This commit replaces the travis CI with Github's new actions.

It's just a proposal, however it's integrations are pretty nice and one doesn't need to visit another slow website to check which branch of the CI actually failed.

I tried to fix the currently failing tests, however those seem to be upstream in the hjson crate?
I'm not exactly sure what's happening though.

The new CI also ensures, that everything compiles on MacOS and Windows.
If this isn't something that's needed or wanted for this crate, I'll just remove it :)

@MarcoIeni
Copy link

you should add

        if: matrix.os == 'ubuntu-latest'

also to rustfmt, since there is no need to check format all the time.

In addition, maybe you want to check rustfmt and clippy only on stable toolchain?

@Nukesor
Copy link
Author

Nukesor commented Dec 27, 2020

@MarcoIeni You're right. I did that for my own projects, but completely forgot about this PR 😅
Commit has been adjusted

@fpoli fpoli mentioned this pull request Feb 1, 2021
@fpoli fpoli mentioned this pull request Mar 4, 2021
@matthiasbeyer
Copy link
Member

This is superseeded by #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants