Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RON format #202

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Add support for RON format #202

merged 1 commit into from
Apr 20, 2021

Conversation

skreborn
Copy link
Contributor

This change set adds support for the RON format.

The files are mostly copied and modified slightly from the existing format parsers, with the addition of handling the unit, character, and optional types.

Resolves #116.

Copy link
Member

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thank you very much for your PR, I love that people contribute to this crate!

I found a few things we have to discuss, feel free to ask questions or teach me where I'm wrong! 😆

src/file/format/ron.rs Outdated Show resolved Hide resolved
src/file/format/ron.rs Outdated Show resolved Hide resolved
src/file/format/ron.rs Outdated Show resolved Hide resolved
src/file/format/ron.rs Outdated Show resolved Hide resolved
@skreborn
Copy link
Contributor Author

I've addressed your comments, hopefully the changes are better now. Let me know if there's anything else!

Copy link
Member

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot for your contribution. Please squash the commits into one and then I think we're ready to go!

@skreborn
Copy link
Contributor Author

Please squash the commits into one and then I think we're ready to go!

Squashed and ready!

@matthiasbeyer matthiasbeyer merged commit 86f8776 into rust-cli:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Ron support
2 participants