Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current master branch does not build with --no-default-features #875

Closed
jessebraham opened this issue Oct 23, 2024 · 2 comments · Fixed by #877
Closed

Current master branch does not build with --no-default-features #875

jessebraham opened this issue Oct 23, 2024 · 2 comments · Fixed by #877

Comments

@jessebraham
Copy link
Member

I've updated the workflow in my fork to include this option, failing run can be seen here:
https://github.com/jessebraham/svd2rust/actions/runs/11481198244

Enabling the yaml feature also does not resolve this:
https://github.com/jessebraham/svd2rust/actions/runs/11481238404

@jannic
Copy link
Member

jannic commented Oct 23, 2024

This is caused by https://github.com/rust-embedded/svd2rust/pull/856/files introducing a settings.yaml file that is parsed using serde_yaml, which is currently an optional dependency.

The easiest solution would be to make that dependency mandatory. Is there anything wrong with that?

The dependency was made optional in #619. That doesn't look like a strict requirement, more like an optimization.

The alternative would be to disable the yaml config file if the dependency is disabled. But IMHO that would be unnecessarily confusing.

@Emilgardis
Copy link
Member

I think it would make sense to make the library work without serde_yaml, there's nothing in the functionality of svd2rust as a library that strictly requires it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants