Skip to content

Commit

Permalink
Do not mention specializing collect
Browse files Browse the repository at this point in the history
In libcore, no adaptor specialize `collect` so I'm not sure why we should.
  • Loading branch information
Philippe-Cholet committed Feb 7, 2024
1 parent d8c785f commit 8d4e042
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ Most of the time, we want specializations of:

Additionally,

- [`collect`](https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.collect)
might make collection faster than calling `next` repeatedly.
- `for_each`, `reduce`, `max/min[_by[_key]]` and `partition` all rely on `fold` so you should specialize it instead.
- `all`, `any`, `find`, `find_map`, `cmp`, `partial_cmp`, `eq`, `ne`, `lt`, `le`, `gt`, `ge` and `position` all rely (by default) on `try_fold`
which we can not specialize on stable rust, so you might want to wait it stabilizes
Expand Down

0 comments on commit 8d4e042

Please sign in to comment.