Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unfold #610

Closed
wants to merge 1 commit into from
Closed

Remove unfold #610

wants to merge 1 commit into from

Conversation

density
Copy link
Contributor

@density density commented Apr 12, 2022

Removes unfold, which is no longer need since from_fn is stable.

Refs #223

@jswrenn
Copy link
Member

jswrenn commented Jun 2, 2022

I'd be happy to merge a PR adding a deprecation notice, but would rather not remove unfold outright at this time. Their signatures are not identical, and so it's completely trivial to switch over to from_fn.

@jswrenn jswrenn closed this Jun 2, 2022
@Philippe-Cholet Philippe-Cholet mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@density @jswrenn