Implement ExactSizeIterator for (Circular)TupleWindows #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a field to know the length of the iterator.
Implemented under the same conditions `Iterator` is implemented. It implements a method `len` which rely on an exact size hint.
Implemented under the same conditions `Iterator` and `ExactSizeIterator` are implemented.
jswrenn
requested changes
Sep 18, 2023
`len` was a duplicate since `Take` also had it. `CircularTupleWindows::next` is how is implemented `Take::next`.
jswrenn
approved these changes
Sep 18, 2023
With the additional condition that `I` is an exact size iterator.
Philippe-Cholet
changed the title
jswrenn
approved these changes
Sep 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #660
Implement
ExactSizeIteratorwithout any additional cost:CircularTupleWindowsby flattenning thestruct Take<I> { iter: I, n: usize }fromiter: Take<TupleWindows<Cycle<I>, T>>intoiter: TupleWindows<Cycle<I>, T>, len: usize.It has the same length as the input (exact size) iterator.
Implement
FusedIteratoras well.TupleWindowsif the input iterator is exact sized. Relies on the fact thatT::num_items() - 1items are collected at definition.