Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unfold for std::iter::from_fn #871

Merged

Conversation

Philippe-Cholet
Copy link
Member

Solves #223. Based on #610 (comment) that suggested to add a deprecation notice instead of removing it directly.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6814180) 94.38% compared to head (db47289) 94.25%.
Report is 2 commits behind head on master.

❗ Current head db47289 differs from pull request most recent head 777b341. Consider uploading reports for the commit 777b341 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   94.38%   94.25%   -0.14%     
==========================================
  Files          48       48              
  Lines        6665     6666       +1     
==========================================
- Hits         6291     6283       -8     
- Misses        374      383       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet
Copy link
Member Author

Philippe-Cholet commented Feb 7, 2024

"semver checks" first failed in CI, I therefore updated the version to "0.13.0".

Copy link
Member

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You've been absolutely killing it with triage lately, and the effort is much appreciated!

@jswrenn jswrenn added this pull request to the merge queue Feb 8, 2024
Merged via the queue into rust-itertools:master with commit 3e47a02 Feb 8, 2024
11 checks passed
@Philippe-Cholet Philippe-Cholet deleted the deprecate-unfold-for-from_fn branch February 8, 2024 12:53
@Philippe-Cholet
Copy link
Member Author

@jswrenn Yes after some PRs of mine that resolved old issues and closed a few PRs and some (I think reasonable) triage, we finally have less than 100 issues and 30 PRs. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants