Auto merge of rust-lang#138271 - mu001999-contrib:fix-138234, r=<try>

Keep space if arg does not follow punctuation when lint unused parens

Fixes rust-lang#138234

If the arg follows punctuation, still pass `left_pos` with `None` and no space will be added, else then pass `left_pos` with `Some(arg.span.lo())`, so that we can add the space as expected.

And `emit_unused_delims` can make sure no more space will be added if the expr follows space.

Author: bors

compiler/rustc_lint/src/unused.rs

@@ -922,7 +922,16 @@ trait UnusedDelimLint {
                     return;
                 }
                 for arg in args_to_check {
-                    self.check_unused_delims_expr(cx, arg, ctx, false, None, None, false);
+                    let sm = cx.sess().source_map();
+                    let left_pos = if let Ok(snip) = sm.span_to_prev_source(arg.span)
+                        && !snip.ends_with(|c: char| c.is_ascii_punctuation())
+                    {
+                        Some(arg.span.lo())
+                    } else {
+                        None
+                    };
+
+                    self.check_unused_delims_expr(cx, arg, ctx, false, left_pos, None, false);
                 }
                 return;
             }

tests/ui/lint/unused_parens_follow_ident.rs

@@ -0,0 +1,15 @@
+#![deny(unused_parens)]
+
+macro_rules! wrap {
+    ($name:ident $arg:expr) => {
+        $name($arg);
+    };
+}
+
+fn main() {
+    wrap!(unary(routine())); //~ ERROR unnecessary parentheses around function argument
+    wrap!(unary (routine())); //~ ERROR unnecessary parentheses around function argument
+}
+
+fn unary(_: ()) {}
+fn routine() {}

tests/ui/lint/unused_parens_follow_ident.stderr

@@ -0,0 +1,31 @@
+error: unnecessary parentheses around function argument
+  --> $DIR/unused_parens_follow_ident.rs:10:16
+   |
+LL |     wrap!(unary(routine()));
+   |                ^         ^
+   |
+note: the lint level is defined here
+  --> $DIR/unused_parens_follow_ident.rs:1:9
+   |
+LL | #![deny(unused_parens)]
+   |         ^^^^^^^^^^^^^
+help: remove these parentheses
+   |
+LL -     wrap!(unary(routine()));
+LL +     wrap!(unary routine());
+   |
+
+error: unnecessary parentheses around function argument
+  --> $DIR/unused_parens_follow_ident.rs:11:17
+   |
+LL |     wrap!(unary (routine()));
+   |                 ^         ^
+   |
+help: remove these parentheses
+   |
+LL -     wrap!(unary (routine()));
+LL +     wrap!(unary routine());
+   |
+
+error: aborting due to 2 previous errors
+