From 8cacdb50365aa6b95e43895ef74777ee042a7ec4 Mon Sep 17 00:00:00 2001 From: Camelid Date: Thu, 8 Oct 2020 12:55:42 -0700 Subject: [PATCH 1/3] Add post about using regression labels --- .../2020-10-14-regression-labels.md | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 posts/inside-rust/2020-10-14-regression-labels.md diff --git a/posts/inside-rust/2020-10-14-regression-labels.md b/posts/inside-rust/2020-10-14-regression-labels.md new file mode 100644 index 000000000..7edd5085a --- /dev/null +++ b/posts/inside-rust/2020-10-14-regression-labels.md @@ -0,0 +1,53 @@ +--- +layout: post +title: "Marking issues as regressions" +description: "Now anyone can mark issues as regressions!" +author: Camelid +team: the release team +--- + +If you've contributed to Rust before, you have likely used a command like this +to [set labels][rustbot-labeling-docs]: + +> **@rustbot** modify labels: A-typesystem C-enhancement + +Setting labels on issues and pull requests helps us keep track of and filter +issues. There are many kinds of labels you can set to mark an issue +as pertinent to a particular team, related to a part of the compiler, or +what kind of bug it is (a hang, a crash, etc.). + +We also have labels that help us keep track of regressions so that we can +prioritize them and fix them quickly if they are severe. We have three +regression labels, each representing when the regression occurred: + +* `regression-from-stable-to-nightly` +* `regression-from-stable-to-beta` +* `regression-from-stable-to-stable` + +We recently had a case where a [regression was not caught][internals-thread] +before a release because the issue was not marked with a regression label. +So we have now [added the ability][regression-label-pr] for *anyone* to set +regression labels on issues! This is all you have to do to mark an issue as a +regression and it will automatically be prioritized: + +> **@rustbot** modify labels: regression-from-stable-to-{release-channel} + +Just replace `{release-channel}` with one of `nightly`, `beta`, or `stable`, +depending on when the regression occurred, and you're good to go! + +Alternatively, if you are reporting a new regression, you can use the regression +[issue template]. It will guide you through the process of reporting a +regression and providing information that will help us fix the issue. + +Finally, if you have an issue that is *not* a regression, but is still something +that is important to be fixed, you can request prioritization with: + +> **@rustbot** prioritize + +We really appreciate it if you mark all regressions with an appropriate label +so we can track them and fix them as soon as possible! + +[rustbot-labeling-docs]: https://rustc-dev-guide.rust-lang.org/rustbot.html#issue-relabeling +[internals-thread]: https://internals.rust-lang.org/t/1-46-is-unusable-for-me-solved/13161/10 +[regression-label-pr]: https://github.com/rust-lang/rust/pull/77555 +[issue template]: https://github.com/rust-lang/rust/issues/new/choose From 41820b3d1b34dd1480b31516cdbc606da71999f8 Mon Sep 17 00:00:00 2001 From: Camelid Date: Fri, 16 Oct 2020 18:43:00 -0700 Subject: [PATCH 2/3] Move to main blog and future-date post date --- ...10-14-regression-labels.md => 2020-10-20-regression-labels.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename posts/{inside-rust/2020-10-14-regression-labels.md => 2020-10-20-regression-labels.md} (100%) diff --git a/posts/inside-rust/2020-10-14-regression-labels.md b/posts/2020-10-20-regression-labels.md similarity index 100% rename from posts/inside-rust/2020-10-14-regression-labels.md rename to posts/2020-10-20-regression-labels.md From 9d7fff10737f31e939b0ea31e2a41a0ba8d7db20 Mon Sep 17 00:00:00 2001 From: Camelid Date: Fri, 16 Oct 2020 18:43:48 -0700 Subject: [PATCH 3/3] Make more approachable to non-contributors --- posts/2020-10-20-regression-labels.md | 37 ++++++++++----------------- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/posts/2020-10-20-regression-labels.md b/posts/2020-10-20-regression-labels.md index 7edd5085a..99e3b0439 100644 --- a/posts/2020-10-20-regression-labels.md +++ b/posts/2020-10-20-regression-labels.md @@ -6,34 +6,25 @@ author: Camelid team: the release team --- -If you've contributed to Rust before, you have likely used a command like this -to [set labels][rustbot-labeling-docs]: - -> **@rustbot** modify labels: A-typesystem C-enhancement - -Setting labels on issues and pull requests helps us keep track of and filter -issues. There are many kinds of labels you can set to mark an issue -as pertinent to a particular team, related to a part of the compiler, or -what kind of bug it is (a hang, a crash, etc.). - -We also have labels that help us keep track of regressions so that we can -prioritize them and fix them quickly if they are severe. We have three -regression labels, each representing when the regression occurred: - -* `regression-from-stable-to-nightly` -* `regression-from-stable-to-beta` -* `regression-from-stable-to-stable` +The Rust project gets many issues filed every day, and we need to keep track +of them all to make sure we don't miss anything. To do that we use GitHub's +issue labels feature, and we need your help to make sure we fix regressions +as soon as possible! + +We have many issue labels that help us organize our issues, and we have a few +in particular that mark an issue as a regression. These labels will ping a Rust +working group called the [*prioritization working group*][wg-prioritization], +whose members will work to determine the severity of an issue and then +prioritize it. But, this won't happen unless someone marks the issue with one +of those labels! We recently had a case where a [regression was not caught][internals-thread] before a release because the issue was not marked with a regression label. So we have now [added the ability][regression-label-pr] for *anyone* to set regression labels on issues! This is all you have to do to mark an issue as a -regression and it will automatically be prioritized: - -> **@rustbot** modify labels: regression-from-stable-to-{release-channel} +regression and it will automatically ping people to prioritize it: -Just replace `{release-channel}` with one of `nightly`, `beta`, or `stable`, -depending on when the regression occurred, and you're good to go! +> **@rustbot** modify labels: regression-untriaged Alternatively, if you are reporting a new regression, you can use the regression [issue template]. It will guide you through the process of reporting a @@ -47,7 +38,7 @@ that is important to be fixed, you can request prioritization with: We really appreciate it if you mark all regressions with an appropriate label so we can track them and fix them as soon as possible! -[rustbot-labeling-docs]: https://rustc-dev-guide.rust-lang.org/rustbot.html#issue-relabeling +[wg-prioritization]: https://rust-lang.github.io/compiler-team/working-groups/prioritization [internals-thread]: https://internals.rust-lang.org/t/1-46-is-unusable-for-me-solved/13161/10 [regression-label-pr]: https://github.com/rust-lang/rust/pull/77555 [issue template]: https://github.com/rust-lang/rust/issues/new/choose