Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 5.1: grammatical number disagreement #2858

Closed
2 tasks done
jruderman opened this issue Sep 9, 2021 · 0 comments · Fixed by rust-lang/rust#92231
Closed
2 tasks done

Chapter 5.1: grammatical number disagreement #2858

jruderman opened this issue Sep 9, 2021 · 0 comments · Fixed by rust-lang/rust#92231
Milestone
ch5

Comments

@jruderman
Copy link
Contributor

  • I have checked the latest main branch to see if this has already been fixed
  • I have searched existing issues and pull requests for duplicates

URL to the section(s) of the book with this problem:

https://doc.rust-lang.org/book/ch05-01-defining-structs.html

Description of the problem:

This is a deliberate choice because we want instances of this struct to own all of its data and for that data to be valid for as long as the entire struct is valid.

"instances ... its data" and "instances ... the entire struct"

Suggested fix:

  • Change "instances" to "each instance"
@carols10cents carols10cents added this to the ch5 milestone Sep 17, 2021
carols10cents added a commit that referenced this issue Dec 23, 2021
@carols10cents
Fix number disagreement. Fixes #2858.
8ac829c
@ehuss ehuss mentioned this issue Dec 23, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 23, 2021
@matthiaskrgr
Rollup merge of rust-lang#92231 - ehuss:update-books, r=ehuss
996fb28 
Update books

## nomicon

1 commits in 49681ea4a9fa81173dbe9ffed74b4d4a35eae9e3..c05c452b36358821bf4122f9c418674edd1d713d
2021-11-24 16:27:28 +0900 to 2021-12-13 15:23:48 +0900
- Update the guidance on uninitialized data with ptr::addr_of_mut (rust-lang/nomicon#325)

## reference

3 commits in 954f3d441ad880737a13e241108f791a4d2a38cd..06f9e61931bcf58b91dfe6c924057e42ce273ee1
2021-11-29 11:11:30 -0800 to 2021-12-17 07:31:40 -0800
- keep consistent for primitive types (rust-lang/reference#1118)
- README.md: link to mdbook docs (rust-lang/reference#1117)
- Say that `...` range patterns are rejected in the 2021 edition (rust-lang/reference#1114)

## book

4 commits in 5f9358faeb1f46e19b8a23a21e79fd7fe150491e..8a0bb3c96e71927b80fa2286d7a5a5f2547c6aa4
2021-12-05 21:33:16 -0500 to 2021-12-22 20:54:27 -0500
- Propagate edits back
- Fix number disagreement. Fixes rust-lang/book#2858.
- Wrap some code in main to make scopes clearer. Fixes rust-lang/book#2830.
- Respond to ch5 nostarch edits

## rustc-dev-guide

9 commits in a374e7d8bb6b79de45b92295d06b4ac0ef35bc09..9bf0028b557798ddd07a6f652e4d0c635d3d6620
2021-12-03 09:26:47 -0800 to 2021-12-20 21:53:57 +0900
- remove rustfix item in test intro (rust-lang/rustc-dev-guide#1277)
- Move date-check comment to fix Markdown syntax
- Update humor docs for special-casing ferris emoji
- Fix some broken links (rust-lang/rustc-dev-guide#1274)
- Update rustdoc internals
- Update HIR chapter to use `HirId` instead of `NodeId`
- Fix some broken links
- Update src/getting-started.md
- Improve documentation on r?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ch5
Development

Successfully merging a pull request may close this issue.

Update books ehuss/rust
2 participants
@carols10cents @jruderman