From 7ac6873df257a8abe31beb39953b179c8366ecaf Mon Sep 17 00:00:00 2001
From: Lin Yihai <linyihai@huawei.com>
Date: Wed, 29 Nov 2023 17:37:01 +0800
Subject: [PATCH] Add test case for `cargo uninstall` while try to uninstalling
 a running Bin.

---
 src/cargo/ops/cargo_uninstall.rs |  6 ++-
 tests/testsuite/install.rs       | 75 ++++++++++++++++++++++++++++++++
 2 files changed, 79 insertions(+), 2 deletions(-)

diff --git a/src/cargo/ops/cargo_uninstall.rs b/src/cargo/ops/cargo_uninstall.rs
index 57d72f9c90d7..caad4fa74603 100644
--- a/src/cargo/ops/cargo_uninstall.rs
+++ b/src/cargo/ops/cargo_uninstall.rs
@@ -147,12 +147,14 @@ fn uninstall_pkgid(
         tracker.remove(pkgid, &bins);
     }
 
+    // This should have been handled last, but now restore it to reproduce the problem on the Windows platform.
+    // See issue #3364.
+    tracker.save()?;
+
     for bin in to_remove {
         config.shell().status("Removing", bin.display())?;
         paths::remove_file(bin)?;
     }
 
-    // Only Save the tracker when remove Bin successfully.
-    tracker.save()?;
     Ok(())
 }
diff --git a/tests/testsuite/install.rs b/tests/testsuite/install.rs
index fd53b607bf3b..f6e0b21a3411 100644
--- a/tests/testsuite/install.rs
+++ b/tests/testsuite/install.rs
@@ -2507,3 +2507,78 @@ fn install_incompat_msrv() {
 ")
         .with_status(101).run();
 }
+
+#[cargo_test]
+fn uninstall_running_binary() {
+    Package::new("foo", "0.0.1")
+    .file("src/lib.rs", "")
+    .file("Cargo.toml", r#"
+    [package]
+    name = "foo"
+    version = "0.0.1"
+    
+    [[bin]]
+    name = "foo"
+    path = "src/main.rs"
+"#,)
+    .file(
+        "src/main.rs",
+        r#"
+        use std::{{thread, time}}; 
+        fn main() {
+            println!("start longrunning job.");
+            thread::sleep(time::Duration::from_secs(3));
+            println!("end longrunning job.");
+        }
+"#)
+    .publish();
+
+    cargo_process("install foo")
+        .with_stderr(
+            "\
+[UPDATING] `[..]` index
+[DOWNLOADING] crates ...
+[DOWNLOADED] foo v0.0.1 (registry [..])
+[INSTALLING] foo v0.0.1
+[COMPILING] foo v0.0.1
+[FINISHED] release [optimized] target(s) in [..]
+[INSTALLING] [CWD]/home/.cargo/bin/foo[EXE]
+[INSTALLED] package `foo v0.0.1` (executable `foo[EXE]`)
+[WARNING] be sure to add `[..]` to your PATH to be able to run the installed binaries
+",
+        )
+        .run();
+    assert_has_installed_exe(cargo_home(), "foo");
+
+    use cargo_util::ProcessBuilder;
+    use std::thread;
+    let foo_bin = cargo_test_support::install::cargo_home()
+        .join("bin")
+        .join(cargo_test_support::install::exe("foo"));
+
+    let t = thread::spawn(|| ProcessBuilder::new(foo_bin).exec().unwrap());
+
+    cargo_process("uninstall foo")
+        .with_status(101)
+        .with_stderr_contains("[ERROR] failed to remove file `[CWD]/home/.cargo/bin/foo[EXE]`")
+        .run();
+    assert_has_installed_exe(cargo_home(), "foo");
+
+    t.join().unwrap();
+    cargo_process("uninstall foo")
+        .with_stderr("[REMOVING] [CWD]/home/.cargo/bin/foo[EXE]")
+        .run();
+    cargo_process("install foo")
+    .with_stderr(
+        "\
+[UPDATING] `[..]` index
+[INSTALLING] foo v0.0.1
+[COMPILING] foo v0.0.1
+[FINISHED] release [optimized] target(s) in [..]
+[INSTALLING] [CWD]/home/.cargo/bin/foo[EXE]
+[INSTALLED] package `foo v0.0.1` (executable `foo[EXE]`)
+[WARNING] be sure to add `[..]` to your PATH to be able to run the installed binaries
+",
+    )
+    .run();
+}