Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give lint groups have a lower default default priority #13565

Open
Beanie496 opened this issue Mar 8, 2024 · 3 comments
Open

Give lint groups have a lower default default priority #13565

Beanie496 opened this issue Mar 8, 2024 · 3 comments
Labels
A-lints-table Area: [lints] table C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.

Comments

@Beanie496
Copy link

Problem

Currently, giving a level to a lint group (like pedantic in clippy) will override a level given to a specific lint if it's higher than the lint alphabetically. For example, pedantic = "deny" will override ptr_as_ptr = "allow" but not option_option = "allow".

Proposed Solution

Give the lint groups a default priority of -1.

Notes

No response
@Beanie496 Beanie496 added C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage. labels Mar 8, 2024
@epage epage added A-lints-table Area: [lints] table S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. and removed S-triage Status: This issue is waiting on initial triage. labels Mar 8, 2024
@epage
Copy link
Contributor

epage commented Mar 8, 2024

Not changing the priority but changing our sorting within a priority was a future possibility from the RFC.

The first step would be #12918.

@Beanie496
Copy link
Author

Ah, I didn't know about the RFC - thanks. My suggestion is probably redundant then.

@epage
Copy link
Contributor

epage commented Mar 10, 2024

Re-opening so we have this as a place to discuss this if/when we get to that point.

@epage epage reopened this Mar 10, 2024
@edmorley edmorley mentioned this issue Mar 21, 2024
Merged
dzuelke added a commit to heroku/buildpacks-php that referenced this issue Jul 29, 2024
@dzuelke
fix pedantic=warn cippy error
06770cd 
rust-lang/cargo#13565
@epage epage mentioned this issue Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints-table Area: [lints] table C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @Beanie496