Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Cargo passes wrong rlib path for doctests #6954

Open
jonas-schievink opened this issue May 17, 2019 · 3 comments
Open

Nightly Cargo passes wrong rlib path for doctests #6954

jonas-schievink opened this issue May 17, 2019 · 3 comments
Labels
C-bug Category: bug S-propose-close Status: A team member has nominated this for closing, pending further input from the team Z-build-plan Nightly: --build-plan feature

Comments

@jonas-schievink
Copy link
Contributor

Problem

On the current nightly, with rustc 1.36.0-nightly (7d5aa4332 2019-05-16) and cargo 1.36.0-nightly (c4fcfb725 2019-05-15), my build-plan crate fails to compile doctests (of which there are none) during cargo test.

It fails while trying to build the crate for doctests, with this error:

   Doc-tests build-plan
error: extern location for serde does not exist: /home/jonas/dev/build-plan/target/debug/deps/libserde-270f7cf6cecf499d.rlib

error[E0463]: can't find crate for `serde`
  --> /home/jonas/dev/build-plan/src/lib.rs:14:1
   |
14 | extern crate serde;
   | ^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to 2 previous errors

A failing CI build can be seen here: https://travis-ci.org/jonas-schievink/build-plan/builds/533879431?utm_medium=notification&utm_source=email

The cause of this must be something in the Cargo update PR rust-lang/rust#60874, since it still works fine on the nightly before that (cargo 1.36.0-nightly (759b6161a 2019-05-06))

Steps

  1. git clone https://github.com/jonas-schievink/build-plan.git
  2. cd build-plan
  3. cargo test

Possible Solution(s)

Notes

Output of cargo version: cargo 1.36.0-nightly (c4fcfb7 2019-05-15)

@jonas-schievink jonas-schievink added the C-bug Category: bug label May 17, 2019
@alexcrichton
Copy link
Member

Thanks for the report! This looks specifically related to the integration test where cargo build --build-plan is deleting artifacts. I think this is caused by #6883 and is likely related to this block, but --build-plan is an unstable option and candidate for breakage anyway.

@jonas-schievink
Copy link
Contributor Author

Ah yes, that makes sense. I'm kind of surprised that a --build-plan invocation is deleting artifacts though.

@ehuss ehuss added the Z-build-plan Nightly: --build-plan feature label Jul 28, 2019
@epage epage added the S-triage Status: This issue is waiting on initial triage. label Nov 1, 2023
@ehuss ehuss added S-propose-close Status: A team member has nominated this for closing, pending further input from the team and removed S-triage Status: This issue is waiting on initial triage. labels Nov 22, 2023
@weihanglo
Copy link
Member

Before closing, could we add a statement to the unstable doc build-plan for the deprecation, if we decide to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug S-propose-close Status: A team member has nominated this for closing, pending further input from the team Z-build-plan Nightly: --build-plan feature
Projects
None yet
Development

No branches or pull requests

5 participants