Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean package perf improvements #13818

Merged
merged 8 commits into from
May 2, 2024
Merged

Clean package perf improvements #13818

merged 8 commits into from
May 2, 2024

Commits on Apr 27, 2024

  1. Do not call rm_rf_glob in a loop for paths that do not depend on file… 

    …_types
    @osiewicz
    osiewicz committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    d4c83ee View commit details
    Browse the repository at this point in the history

  2. Add rm_rf_prefix_list

    @osiewicz
    osiewicz committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    9c685ab View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Clean non-filetype based entries just once

    @osiewicz
    osiewicz committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c770700 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Treat calls to rm_rf_prefix_list as idempotent 

    Starting with this commit we deduplicate calls to rm_rf_prefix_list by crate name and not by directory; this can lead to more calls to rm_rf_prefix_list (especially in presence of multiple -p arguments),
but it is also more transparent in terms of progress reporting (we're just storing away whether a given directory + glob pair has already been removed)
    @osiewicz
    osiewicz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d33ef8f View commit details
    Browse the repository at this point in the history

  2. Clean up commentary for new code

    @osiewicz
    osiewicz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    634dca4 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Update src/cargo/ops/cargo_clean.rs 

    Change Rc<str> to &str

Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com>
    @osiewicz @weihanglo
    osiewicz and weihanglo authored May 2, 2024
    Configuration menu
    Copy the full SHA
    a49a2b9 View commit details
    Browse the repository at this point in the history

  2. fixup! Update src/cargo/ops/cargo_clean.rs

    @osiewicz
    osiewicz committed May 2, 2024
    Configuration menu
    Copy the full SHA
    574d086 View commit details
    Browse the repository at this point in the history

  3. feedback: rewrite doc comment for rm_rf_prefix_list

    @osiewicz
    osiewicz committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9c1139e View commit details
    Browse the repository at this point in the history