[beta-1.91] chore: Disabled reserved_windows_name test temporaily #16050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
weihanglo
changed the title
Unclear why it wasn't missing before. The line was added five years ago. Seems it should be available. https://github.com/actions/runner-images/blob/75ec4229/images/ubuntu/scripts/build/install-rust.sh#L19-L20 Maybe due to recent pin/unpin 1.89 issue? actions/runner-images@69c94f5b
The test exercises a regression of extra `-Zbuild-std-features` overriding the entire default-features set. However, after rust-lang/rust 146317 panic_immediate_abort became a codegen flag not a Cargo feature anymore. We pick another `optimize_for_size` feature flag to ensure the regression case is still covered. To verify `optimize_for_size` actually triggers the regression, git revert f004691 and changes to `-Zbuild-std-features=optimize_for_size`. Alternatively, we can just drop this test.
rustbot
added
the
A-infrastructure
epage
approved these changes
Oct 5, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backports
In order to make CI pass, the following PRs are also cherry-picked: