Split fallible infallible folding #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let's merge this @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
lowr
added a commit
to lowr/rust-analyzer
that referenced
this pull request
Oct 13, 2022
Two things: - `TypeFolder` has been split into `TypeFolder` and `FallibleTypeFolder` (rust-lang/chalk#772) - `ProjectionTy::self_type_parameter()` has been removed (rust-lang/chalk#778)
bors
added a commit
that referenced
this pull request
Oct 13, 2022
Fix parameter for `Interner` in `derive(FallibleTypeFolder)` macro In custom derive macro for `FallibleTypeFolder` introduced in #772, there's one occurrence of raw type parameter that is not guaranteed to exist. This patch replaces it with `#interner` to be interpolated at proc macro runtime like in other methods.
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Oct 16, 2022
Bump chalk There's a bug in current chalk that prevents us from properly supporting GATs, which is supposed to be fixed in v0.86. Note the following: - v0.86 is only going to be released next Sunday so I'll keep this PR as draft until then. - This doesn't compile without rust-lang/chalk#779, which I hope will be included in v0.86. I confirmed this compiles with it locally. Two breaking changes from v0.84: - `TypeFolder` has been split into `TypeFolder` and `FallibleTypeFolder` (rust-lang/chalk#772) - `ProjectionTy::self_type_parameter()` has been removed (rust-lang/chalk#778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For folding operations that cannot fail, the existing fallible folding trait is a little unergonomic. This PR introduces an infallible folder trait that can be used as a more ergonomic alternative in such cases, reflecting the status quo in rustc.
Infallible folders must however also implement the fallible trait (it's a supertrait of the infallible one), but such implementation should merely delegate to the infallible trait. Coherence rules unfortunately do not permit this to be provided by blanket implementation, however delegating implementations can be simply derived on infallible folders via the
chalk_derive::FallibleTypeFoldermacro.r? @jackh726