Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update syn to 2.0 #793

Merged
merged 1 commit into from
Mar 27, 2023
Merged

update syn to 2.0 #793

merged 1 commit into from
Mar 27, 2023

Conversation

fee1-dead
Copy link
Member

No description provided.

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 27, 2023

📌 Commit 9233e54 has been approved by jackh726

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 27, 2023

⌛ Testing commit 9233e54 with merge a618c6c...

@bors
Copy link
Contributor

bors commented Mar 27, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing a618c6c to master...

@bors bors merged commit a618c6c into rust-lang:master Mar 27, 2023
@lqd
Copy link
Member

lqd commented Mar 27, 2023

Interesting, this adds syn 2 but doesn't remove syn 1. Do you know if other dependencies have also switched to syn 2 and released a new version already ? Will syn be duplicated in rustc as well ?

@compiler-errors
Copy link
Member

Dependencies that introduce syn:

  • tracing v0.1.29
  • salsa-macros v0.16.0 (via salsa v0.16.0)
  • string_cache v0.8.2 (via serde-derive v1.0.130, via serde v1.0.130)

so those will need to be upgraded

@davidbarsky
Copy link
Contributor

tracing v0.1.29

Yeah, I'm (pretty sure) we're on it.

@lqd
Copy link
Member

lqd commented Mar 29, 2023

I found the rustc tracking issue for this migration, with the other dependencies introducing syn and requiring upgrades there, at rust-lang/rust#109302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants