From 3361b8b114ceef4a45e08cfac14046cb56d90c2a Mon Sep 17 00:00:00 2001
From: Jacob Hoffman-Andrews <github@hoffman-andrews.com>
Date: Wed, 14 Oct 2020 01:08:18 -0700
Subject: [PATCH] menus: Tweak JS handling of clicks.

Prior to this change, if you clicked a menu to open it, then clicked to
close it, the menu heading would still have a grey background
highlighting it. That's due to a CSS rule in pure-menu that causes
focused elements to have a highlighted color. To fix: unfocus the menu
when it is closed via mouse (but leave it focused when it is closed via
keyboard).

Remove a mouseover handler that is not needed anymore.
---
 static/menu.js | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/static/menu.js b/static/menu.js
index 275e2921f..87e116a6e 100644
--- a/static/menu.js
+++ b/static/menu.js
@@ -54,6 +54,7 @@
         }
         if (this.parentNode === currentMenu) {
             closeMenu();
+            this.blur();
         } else {
             if (currentMenu) closeMenu();
             openMenu(this.parentNode);
@@ -61,17 +62,6 @@
         e.preventDefault();
         e.stopPropagation();
     };
-    function menuMouseOver(e) {
-        if (currentMenu) {
-            if (e.target.className.indexOf("pure-menu-link") !== -1) {
-                e.target.focus();
-                if (e.target.parentNode.className.indexOf("pure-menu-has-children") !== -1 && e.target.parentNode !== currentMenu) {
-                  closeMenu();
-                  openMenu(e.target.parentNode);
-                }
-            }
-        }
-    }
     function menuKeyDown(e) {
         if (currentMenu) {
             var children = currentMenu.querySelector(".pure-menu-children");
@@ -195,7 +185,6 @@
         menu.firstElementChild.setAttribute("aria-haspopup", "menu");
         menu.firstElementChild.nextElementSibling.setAttribute("role", "menu");
         menu.firstElementChild.addEventListener("click", menuOnClick);
-        menu.addEventListener("mouseover", menuMouseOver);
     }
     document.documentElement.addEventListener("keydown", menuKeyDown);
 })();