From bf8bfe710fe157c572fd36496c5ef914668492f5 Mon Sep 17 00:00:00 2001 From: Denis Cornehl Date: Fri, 1 Jan 2021 13:54:55 +0100 Subject: [PATCH 1/2] Fix collecting github stats after timezone-migration --- src/utils/github_updater.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/github_updater.rs b/src/utils/github_updater.rs index 06cb518f5..e044d12c7 100644 --- a/src/utils/github_updater.rs +++ b/src/utils/github_updater.rs @@ -267,7 +267,7 @@ impl GithubUpdater { &repo.id, &repo.name_with_owner, &repo.description, - &repo.pushed_at.map(|time| time.naive_utc()), + &repo.pushed_at, &(repo.stargazer_count as i32), &(repo.fork_count as i32), &(repo.issues.total_count as i32), From ac5b73880713f67322b9099c32203a1345ce39b5 Mon Sep 17 00:00:00 2001 From: Denis Cornehl Date: Fri, 1 Jan 2021 14:24:17 +0100 Subject: [PATCH 2/2] fix new clippy warnings --- crates/font-awesome-as-a-crate/src/lib.rs | 2 +- src/web/rustdoc.rs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/font-awesome-as-a-crate/src/lib.rs b/crates/font-awesome-as-a-crate/src/lib.rs index c249d0c50..a34738d59 100644 --- a/crates/font-awesome-as-a-crate/src/lib.rs +++ b/crates/font-awesome-as-a-crate/src/lib.rs @@ -81,7 +81,7 @@ Get a fontawesome svg file by its name. */ pub fn svg(type_: Type, name: &str) -> Result<&'static str, NameError> { let svg = fontawesome_svg(type_.as_str(), name); - if svg == "" { + if svg.is_empty() { return Err(NameError); } Ok(svg) diff --git a/src/web/rustdoc.rs b/src/web/rustdoc.rs index c4bd97be5..af468ddb1 100644 --- a/src/web/rustdoc.rs +++ b/src/web/rustdoc.rs @@ -427,7 +427,7 @@ pub fn rustdoc_html_server_handler(req: &mut Request) -> IronResult { .recently_accessed_releases .record(krate.crate_id, krate.release_id, target); - let target = if target == "" { + let target = if target.is_empty() { String::new() } else { format!("{}/", target) @@ -656,7 +656,7 @@ mod test { use crate::test::*; use kuchiki::traits::TendrilSink; use reqwest::StatusCode; - use std::{collections::BTreeMap, iter::FromIterator}; + use std::collections::BTreeMap; fn try_latest_version_redirect( path: &str, @@ -1175,7 +1175,7 @@ mod test { path: &str, links: &[(&str, &str)], ) -> Result<(), failure::Error> { - let mut links = BTreeMap::from_iter(links.iter().copied()); + let mut links: BTreeMap<_, _> = links.iter().copied().collect(); for (platform, link, rel) in get_platform_links(path, web)? { assert_eq!(rel, "nofollow");