Sort platforms list #2170
Merged
Sort platforms list #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Perhaps I'm wrong, but:
When I look at our rustwide-builder, specifically here, it looks like the default target is the first to be added to the list of targets, and then the other targets follow.
The successful_targets vec is then stored in the database, and then used in the code you changed.
This means that currently, the default target is the first in the list, and this would change with this PR. Or am I missing something?
syphar
added
S-waiting-on-author
|
It would change it indeed. But I don't consider it a problem: it'll remain the default platform, no need to put it at the op of the list. I was also thinking about making the current platform text bold or something along the line (in another PR). |
syphar
approved these changes
Jul 29, 2023
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see:
it's currently complicated to find the correct one from the list. However, I'm not sure if it's the best approach to sort the list every time or if we should insert it correctly instead. But in the second case, that would mean updating all the entries in the DB. Not sure which solution you prefer?