From 41fe944008da127a3972d806fe6b02234d5d6ba6 Mon Sep 17 00:00:00 2001 From: Joshua Nelson Date: Fri, 29 May 2020 10:06:50 -0400 Subject: [PATCH] Fix 404 on /releases/feed --- src/web/page.rs | 6 ++++-- src/web/releases.rs | 10 +++++++++- templates/releases_feed.hbs | 2 +- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/web/page.rs b/src/web/page.rs index ef10f01c9..bc3ae1c80 100644 --- a/src/web/page.rs +++ b/src/web/page.rs @@ -120,8 +120,10 @@ impl Serialize for Page { // adding the someness of the global alert to the total. `true` // is 1 and `false` is 0, so it increments if the value is some (and therefore // needs to be serialized) - let mut state = - serializer.serialize_struct("Page", 9 + crate::GLOBAL_ALERT.is_some() as usize)?; + let mut state = serializer.serialize_struct( + "Page", + 8 + crate::GLOBAL_ALERT.is_some() as usize + self.title.is_some() as usize, + )?; if let Some(ref title) = self.title { state.serialize_field("title", title)?; diff --git a/src/web/releases.rs b/src/web/releases.rs index f45928491..d79d4509a 100644 --- a/src/web/releases.rs +++ b/src/web/releases.rs @@ -670,7 +670,7 @@ pub fn build_queue_handler(req: &mut Request) -> IronResult { #[cfg(test)] mod tests { use super::*; - use crate::test::wrapper; + use crate::test::{assert_success, wrapper}; use serde_json::json; #[test] @@ -1060,4 +1060,12 @@ mod tests { assert_eq!(correct_json, serde_json::to_value(&release).unwrap()); } + + #[test] + fn release_feed() { + wrapper(|env| { + let web = env.frontend(); + assert_success("/releases/feed", web) + }) + } } diff --git a/templates/releases_feed.hbs b/templates/releases_feed.hbs index f3666fc7b..e60c4e1c1 100644 --- a/templates/releases_feed.hbs +++ b/templates/releases_feed.hbs @@ -7,7 +7,7 @@ urn:docs-rs:{{cratesfyi_version_safe}} -{{content[0].release_time_rfc3339}} +{{content.[0].release_time_rfc3339}} {{#each content}} {{name}}-{{version}}