Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document the slot module #1

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Conversation

kamalmarhubi
Copy link
Contributor

No description provided.

@kamalmarhubi
Copy link
Contributor Author

@alexcrichton I'm super excited about this library and have been reading through. I found parts of Slot hard to grasp, particularly cancellation, and ended up documenting it. I'm doing the same with other parts as I read through. Let me know if you want other PRs!

@kamalmarhubi
Copy link
Contributor Author

I also added a couple of TODOs that look like things that could make sense. Happy to actually do those if they do make sense.

@alexcrichton
Copy link
Member

Thanks! This library is currently seriously under-documented, and I've got a huge amount of documentation I'd want to add. The implementation of Slot is massively tricky and isn't really currently intended for anyone to read but me, unfortunately. Once this starts getting further along I'll be sure to add them plus many more!

@kamalmarhubi
Copy link
Contributor Author

kamalmarhubi commented Jun 8, 2016

Yeah I figured it might be in too early a state for PRs. FWIW, I'll continue adding docs in my doc branch as I get more understanding of how this fits together, and how to use it. Also some experiments in other branches, eg a basic http multiplexer and a threadpool-based executor for fs operations so far.

@kamalmarhubi
Copy link
Contributor Author

Also consider this an offer to write some docs :-)

@alexcrichton
Copy link
Member

Nice! We talked last night, but I'll try to prioritize soon to write docs for all this stuff as well, especially the particularly tricky parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants