Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set MSRV to 1.66 and edition to 2021 #59

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

weihanglo
Copy link
Member

Some new API were already used

  • format arg capture (1.58)
  • std::os::fd (1.66)

A bump is inevitably coming.

Cargo.toml Outdated Show resolved Hide resolved
Some new API were already used

* format arg capture (1.58)
* `std::os::fd` (1.66)

A bump is inevitably coming.
@weihanglo weihanglo changed the title chore: set MSRV to 1.66.1 and edition to 2021 chore: set MSRV to 1.66 and edition to 2021 Oct 8, 2023
@weihanglo
Copy link
Member Author

@petrochenkov, do you know who's the owner of this repo, and how the release process look like?

@petrochenkov
Copy link
Contributor

@weihanglo
I can publish new versions of this crate now.

@petrochenkov
Copy link
Contributor

Could you add a CI check for the minimum supported version?
Example: https://github.com/mozilla/cbindgen/blob/master/.github/workflows/cbindgen.yml#L32-L38

@weihanglo
Copy link
Member Author

Updated. Let me know if it is too excessive, and we can slim it down a bit.

@petrochenkov
Copy link
Contributor

Tests are hanging since yesterday, so something is probably wrong with CI changes (missing -latest on macos and windows?).

@weihanglo
Copy link
Member Author

Embarrassing 😆.

@petrochenkov, just updated. Thank you for the catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants