Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the fixed-width integer aliases #1304

Closed
gnzlbg opened this issue Mar 14, 2019 · 0 comments · Fixed by #1379
Closed

Deprecate the fixed-width integer aliases #1304

gnzlbg opened this issue Mar 14, 2019 · 0 comments · Fixed by #1379

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 14, 2019 •
edited
Loading

We do guarantee that the fixed-width integer types {i,u}{8,16,32,64} are layout compatible with C's {u,}int{8,16,32,64}_t.

There is no need to provide type aliases (e.g. libc::uint64_t) for these, in the same way that we don't provide a libc::c_bool type alias for bool.

Note that c_float and c_double aren't necessarily layout compatible with f32 and f64.
@gnzlbg gnzlbg mentioned this issue Mar 14, 2019
Closed
@gnzlbg gnzlbg changed the title Deprecate the fixed-width integer and float aliases Deprecate the fixed-width integer aliases Mar 25, 2019
@gnzlbg gnzlbg mentioned this issue Mar 27, 2019
Merged
gnzlbg added a commit to gnzlbg/libc that referenced this issue May 29, 2019
@gnzlbg
Deprecates fixed-width integer type aliases
afa3edf 
Closes rust-lang#1304 .
@gnzlbg gnzlbg mentioned this issue May 29, 2019
Merged
bors added a commit that referenced this issue May 29, 2019
@bors
Auto merge of #1379 - gnzlbg:deprecate_fixed_width_ints, r=gnzlbg
0e702c1 
Deprecate fixed width integer type aliases

cc @emilio - I think it makes sense to ensure that the latest released version of bindgen works properly with this change. That is, that even when asked to use C types from, e.g., `libc::`, it does not use aliases for the fixed-width integer C types (e.g. `libc::int64_t`) but uses Rust primitive types instead (e.g. `u64`).

Closes #1304 .
AzureMarker added a commit to pi-hole/api that referenced this issue Jun 6, 2019
@AzureMarker
Fix deprecated libc integer types
32c24b5 
As of rust-lang/libc#1304 types such as
`libc::int64_t` are deprecated. Instead, we should use the native Rust
types like `i64`, as they are compatible with the C types.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
@AzureMarker AzureMarker mentioned this issue Jun 6, 2019
Merged
@josephlr josephlr mentioned this issue Jun 14, 2019
Closed
@frangio frangio mentioned this issue Jun 17, 2019
Closed
@elichai elichai mentioned this issue Aug 24, 2019
Closed
@JohnTitor JohnTitor mentioned this issue Jul 25, 2020
Closed
@kellda kellda mentioned this issue Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate fixed width integer type aliases gnzlbg/libc
1 participant
@gnzlbg