Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

structs nlmsghdr, nlmsgerr and nlattr added to linux mips musl target #1649

Merged
merged 3 commits into from
Feb 28, 2020
Merged

structs nlmsghdr, nlmsgerr and nlattr added to linux mips musl target #1649

merged 3 commits into from
Feb 28, 2020

Conversation

rfael
Copy link

@rfael rfael commented Jan 29, 2020

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@xen0n
Copy link
Contributor

xen0n commented Jan 31, 2020

The additions look good; while you're at it, would you mind adding the structs for the mips64 targets too? This way things are more consistent.

@rfael
Copy link
Author

rfael commented Jan 31, 2020

I added that struct to mips64 musl target too

@rfael
Copy link
Author

rfael commented Feb 7, 2020

I filled x86 and arm musl targets too

@rfael rfael requested a review from gnzlbg February 18, 2020 11:46
@irexiz irexiz mentioned this pull request Feb 18, 2020
Closed
@JohnTitor
Copy link
Member

r? @JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned gnzlbg Feb 27, 2020
@JohnTitor JohnTitor merged commit 4ddd363 into rust-lang:master Feb 28, 2020
@JohnTitor
Copy link
Member

Thanks!

@bors bors mentioned this pull request Feb 28, 2020
Closed
@rklaehn rklaehn mentioned this pull request Dec 3, 2020
Closed
dvc94ch added a commit to dvc94ch/libc that referenced this pull request Dec 3, 2020
@dvc94ch
Followup to rust-lang#1649.
d7a80e0
bors added a commit that referenced this pull request Dec 3, 2020
@bors
Auto merge of #1985 - dvc94ch:nlmsghdr-musl-aarch64, r=JohnTitor
570d6b0 
Followup to #1649.

When adding `nlmsghdr` for `musl` targets the `aarch64` arch was singled out, not getting the definition. This remedies the problem so that `if-watch` compiles on `aarch64-unknown-linux-musl`.

- [0] https://github.com/dvc94ch/if-watch/issues/3
bors added a commit that referenced this pull request Dec 3, 2020
@bors
Auto merge of #1985 - dvc94ch:nlmsghdr-musl-aarch64, r=JohnTitor
96e6147 
Followup to #1649.

When adding `nlmsghdr` for `musl` targets the `aarch64` arch was singled out, not getting the definition. This remedies the problem so that `if-watch` compiles on `aarch64-unknown-linux-musl`.

- [0] https://github.com/dvc94ch/if-watch/issues/3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@gnzlbg gnzlbg Awaiting requested review from gnzlbg

Assignees

@JohnTitor JohnTitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfael @rust-highfive @xen0n @JohnTitor @gnzlbg