Spelling #2843
Merged
Spelling #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoref
commented
Apr 14, 2023
| // some magic path on Windos that *is* considered absolute. | ||
| // some magic path on Windows that *is* considered absolute. |
| // insufficiently aligned. The only way to achieve that is not not let programs | ||
| // insufficiently aligned. The only way to achieve that is not to let programs |
| // we cannot use xref2; see `compile-fail/stacked-borows/illegal_read4.rs` | ||
| // we cannot use xref2; see `compile-fail/stacked-borrows/illegal_read4.rs` |
There was a problem hiding this comment.
this makes the comment match the path...
|
Thanks, the changes look good! However we don't need 52 commits of this, could you squash this into one? |
|
Sure, as long as you're happy with the changes. I might have time (and a laptop) this afternoon. |
|
I have also reviewed all the changes and I like them. I've been meaning to fix these at some point, just always had other things to worry about first. |
* additional * addresses * aggregates * always * around * beginning * behaviours * borrows * called * canary * deallocated * determine * division * documentation * empty * endianness * ensures * existing * github * hygiene * individual * initialize * instantiate * library * location * miscellaneous * mitigates * needs * nonexistent * occurred * occurring * overridden * parameter * performable * previous * referential * requires * resolved * scenarios * semantics * spurious * structure * subtracting * suppress * synchronization * this * timestamp * to * transferring * unknown * variable * windows Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
I should have asked if you had a preference for the commit message. This is my default, I'm not attached to it or anything else. |
|
Seems fine. Thanks! |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/miri/actions/runs/4699927237#summary-12751183650
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/miri/actions/runs/4699927572#summary-12751184493