Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically build libstd #543

Merged
merged 17 commits into from
Nov 27, 2018
Merged

Automatically build libstd #543

merged 17 commits into from
Nov 27, 2018

Conversation

RalfJung
Copy link
Member

Cc #520

bjorn3
bjorn3 requested changes Nov 25, 2018
View reviewed changes
src/bin/cargo-miri.rs Outdated Show resolved Hide resolved
oli-obk
oli-obk requested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very up to date on the cli working group things, but I think they are at a point where it might make sense to look at the best practices and crates for writing cli tools. Not a blocker for this PR, feel free to punt to an issue and assign to me

src/bin/cargo-miri.rs Outdated Show resolved Hide resolved
src/bin/cargo-miri.rs Outdated Show resolved Hide resolved
src/bin/cargo-miri.rs Outdated Show resolved Hide resolved
src/bin/cargo-miri.rs
}
// The interesting bit: Xargo.toml
File::create(dir.join("Xargo.toml")).unwrap()
.write_all(br#"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put these into files in a separate directory and use include_bytes!?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You think that's worth it? They are rather short.

@RalfJung
Copy link
Member Author

RalfJung commented Nov 27, 2018 •
edited
Loading

I'm not very up to date on the cli working group things, but I think they are at a point where it might make sense to look at the best practices and crates for writing cli tools. Not a blocker for this PR, feel free to punt to an issue and assign to me

Done: #546

oli-obk
oli-obk reviewed Nov 27, 2018
View reviewed changes
src/bin/cargo-miri.rs Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented Nov 27, 2018

needs a rebase

r=me with nit fixed

@RalfJung
Copy link
Member Author

Uh... which directory will this be on Windows? We need to know for CI.^^

@RalfJung
Copy link
Member Author

Uh... now the path is different on Linux and macOS, and travis needs to know that. :/

@RalfJung RalfJung merged commit 80a6e73 into rust-lang:master Nov 27, 2018
@RalfJung RalfJung deleted the auto-libstd branch November 30, 2018 08:26
@oli-obk oli-obk mentioned this pull request Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

@bjorn3 bjorn3 bjorn3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RalfJung @oli-obk @bjorn3