Fix project dirs path

[soc]

ProjectDirs::from("miri", "miri", "miri")

would get you miri\miri on Windows and miri.miri.miri on macOS.

I'm assuming here that your intention was to have only a miri directory on every OS.

[RalfJung]

So on Linux, this remains at ~/.cache/miri?

To fix Windows CI, you'll have to adjust the path here.

[soc]

@RalfJung Yes. The arguments for ProjectDirs::from are qualifier: &str, organization: &str, application: &str, not e. g. linux: &str, macos: &str, windows: &str: https://docs.rs/directories/2.0.1/directories/struct.ProjectDirs.html#method.from

[RalfJung]

I see. Would it make sense for us to use "rust" or "rust-lang" as "organization"?
I don't know what "qualifier" is supposed to mean.

[soc]

Qualifier is for macOS so that ProjectDirs::from("com", "Foo Corp", "Bar App") gets you

Lin: /home/alice/.config/barapp
Win: C:\Users\Alice\AppData\Roaming\Foo Corp\Bar App\config
Mac: /Users/Alice/Library/Preferences/com.Foo-Corp.Bar-App

rust or rust-lang could be an option, too, depends on how you want it to look like on macOS.

If you want to go the full way, you could pick ProjectDirs::from("org", "rust-lang", "miri"), would probably make sense to coordinate with other rust-related projects though, such that it is at least consistent.

[RalfJung]

TBH I care very little about how our paths look like on macOS.^^ I was just wondering what makes most sense.

[RalfJung]

Nobody seemed to care much when I asked on Zulip. So I'd say let's go with org.rust-lang.miri on macOS, unless @oli-obk objects.

[oli-obk]

unless @oli-obk objects.

quite the opposite, let's do this

[RalfJung]

@soc okay so can you make this "org", "rust-lang", "miri"? That will have the effect of using org.rust-lang.miri on macOS and rust-lang\miri on Windows, right?

[soc]

@RalfJung Sorry for the delay, your commit looks good to me. Thanks!

[RalfJung]

No trouble, and thanks for pointing out that we were using this API the wrong way. :)

[soc]

It's been a pleasure! Now I just need to fix cargo and the rest of the ecosystem. :-)