Describe all cases for which the weak dyn keyword is parsed as a keyword
#1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jul 20, 2024
Add missing dyn parse special cases in 2015 edition There were a few more special cases to consider here -> rust-lang/reference#1538
traviscross
approved these changes
Jul 23, 2024
Contributor
traviscross
left a comment
traviscross
left a comment
There was a problem hiding this comment.
Thanks @Veykril. Looks good.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
Add missing dyn parse special cases in 2015 edition There were a few more special cases to consider here -> rust-lang/reference#1538
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
Add missing dyn parse special cases in 2015 edition There were a few more special cases to consider here -> rust-lang/reference#1538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to figure this out for rust-analyzer and noticed that the reference is lacking here (arguably not an important detail as 2015 is rather old :)
Sourced from rustc here: https://github.com/rust-lang/rust/blob/339015920d0787ea14aee05fca2c205683c525f9/compiler/rustc_parse/src/parser/ty.rs#L722-L731 and https://github.com/rust-lang/rust/blob/339015920d0787ea14aee05fca2c205683c525f9/compiler/rustc_parse/src/parser/ty.rs#L84-L99