From 4ec9682a9f2c2697eedbdb06350fa5701fd0e862 Mon Sep 17 00:00:00 2001 From: newpavlov Date: Wed, 4 Jul 2018 18:10:28 +0300 Subject: [PATCH] drawbacks update --- text/0000-min-rust-version.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/text/0000-min-rust-version.md b/text/0000-min-rust-version.md index 65b391d4996..300eb5cccb6 100644 --- a/text/0000-min-rust-version.md +++ b/text/0000-min-rust-version.md @@ -148,11 +148,12 @@ max `version` value from them as a MSRV. If all `cfg`s are false, value in the # Drawbacks [drawbacks]: #drawbacks -- Declaration of MSRV and describe checks does not guarantee that, only -appropriate CI testing. +- Declaration of MSRV, even with the checks, does not guarantee that crate +will work correctly on the specified MSRV, only appropriate CI testing can do that. - More complex dependency versions resolution algorithm. -- MSRV selected by `cargo publish` can be overly conservative. -- MSRV checks will make compiler more complex. +- MSRV selected by `cargo publish` with `rust = "stable"` can be too +conservative. +- Checking `#[stable(since=version)]` of used items will make compiler more complex. # Rationale and Alternatives [alternatives]: #alternatives